Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SANs configurability for API server #6921

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Add SANs configurability for API server #6921

merged 1 commit into from
Nov 1, 2023

Conversation

chrisdoherty4
Copy link
Contributor

@chrisdoherty4 chrisdoherty4 commented Oct 27, 2023 •
edited
Loading

Closes #6863.

Add support for specifying API Server Certificate Subject Alternative Names. This allows users to make requests via domain names or alternate IPs.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0e01fa4) 71.94% compared to head (3f081fa) 71.94%.
Report is 23 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6921   +/-   ##
=======================================
  Coverage   71.94%   71.94%           
=======================================
  Files         532      532           
  Lines       41583    41611   +28     
=======================================
+ Hits        29917    29939   +22     
- Misses       9989     9995    +6     
  Partials     1677     1677
Files Coverage Δ
pkg/api/v1alpha1/cluster.go 80.12% <100.00%> (+0.42%) ⬆️
pkg/api/v1alpha1/cluster_types.go 86.18% <100.00%> (+0.02%) ⬆️
pkg/clusterapi/apibuilder.go 99.22% <100.00%> (+<0.01%) ⬆️
pkg/providers/cloudstack/template.go 88.61% <100.00%> (+0.03%) ⬆️
pkg/providers/docker/docker.go 71.42% <100.00%> (+0.06%) ⬆️
pkg/providers/nutanix/template.go 94.40% <100.00%> (+0.02%) ⬆️
pkg/providers/tinkerbell/template.go 67.80% <100.00%> (+0.06%) ⬆️
pkg/providers/vsphere/template.go 78.27% <100.00%> (+0.06%) ⬆️
pkg/templater/templater.go 67.39% <62.50%> (-9.54%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 27, 2023
@chrisdoherty4 chrisdoherty4 requested a review from a team October 30, 2023 13:43
@chrisdoherty4 chrisdoherty4 marked this pull request as ready for review October 30, 2023 13:43
@chrisdoherty4
Copy link
Contributor Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tatlat
tatlat requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@tatlat tatlat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing this?
func Execute(templateContent string, data interface{}) ([]byte, error) {

@chrisdoherty4
Copy link
Contributor Author

@tatlat Its been modified to include sprig functions instead of copying Helm and Sprig implementations. I wanted some additional functions for the templates.

@chrisdoherty4 chrisdoherty4 requested a review from tatlat November 1, 2023 21:19
@eks-distro-bot eks-distro-bot merged commit 561cb0c into aws:main Nov 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatlat tatlat tatlat approved these changes

Assignees

@tatlat tatlat

Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FQDN SAN for API Server TLS certificate
3 participants
@chrisdoherty4 @eks-distro-bot @tatlat